chore(constraints): break loop early; simplify logic

MetaMask · Oct 9, 2024 · ae521de · ae521de
1 parent 4502883
commit ae521de
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/yarn.config.cjs b/yarn.config.cjs
@@ -761,23 +761,24 @@ function expectConsistentDependenciesAndDevDependencies(Yarn) {
     dependencyIdent,
     dependenciesByRange,
   ] of nonPeerDependenciesByIdent.entries()) {
+    if (dependenciesByRange.size <= 1) {
+      continue;
+    }
     const dependenciesToConsider =
       getInconsistentDependenciesAndDevDependencies(
         dependencyIdent,
         dependenciesByRange,
       );
     const dependencyRanges = [...dependenciesToConsider.keys()].sort();
-    if (dependenciesByRange.size > 1) {
-      for (const dependencies of dependenciesToConsider.values()) {
-        for (const dependency of dependencies) {
-          dependency.error(
-            `Expected version range for ${dependencyIdent} (in ${
-              dependency.type
-            }) to be consistent across monorepo. Pick one: ${inspect(
-              dependencyRanges,
-            )}`,
-          );
-        }
+    for (const dependencies of dependenciesToConsider.values()) {
+      for (const dependency of dependencies) {
+        dependency.error(
+          `Expected version range for ${dependencyIdent} (in ${
+            dependency.type
+          }) to be consistent across monorepo. Pick one: ${inspect(
+            dependencyRanges,
+          )}`,
+        );
       }
     }
   }