Migrate Typescript to ~4.6.3
#1682
Assignees
Labels
Comments
|
Related: I do think that it would be more appropriate to upgrade and consolidate on at least |
MajorLift
added a commit
to MetaMask/eth-json-rpc-provider
that referenced
this issue
Sep 26, 2023
…e monorepo - See MetaMask/core#1718 - See #27 - Closes MetaMask/core#1682
MajorLift
added a commit
that referenced
this issue
Sep 27, 2023
- match compiler options with core monorepo - passes all tests Closes #1682
MajorLift
added a commit
that referenced
this issue
Sep 27, 2023
…e monorepo - See #1718 - See MetaMask/eth-json-rpc-provider#27 - Closes #1682
MajorLift
added a commit
to MetaMask/eth-json-rpc-provider
that referenced
this issue
Sep 28, 2023
…of migration (#28) ## Description - This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo. - This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo. - Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo. ## References - See MetaMask/core#1551 - Closes MetaMask/core#1683 - Closes MetaMask/core#1682 (is superseded by this PR)
MajorLift
added a commit
that referenced
this issue
Sep 29, 2023
…of migration (#28) ## Description - This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo. - This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo. - Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo. ## References - See #1551 - Closes #1683 - Closes #1682 (is superseded by this PR)
MajorLift
added a commit
that referenced
this issue
Oct 11, 2023
- match compiler options with core monorepo - passes all tests Closes #1682
MajorLift
added a commit
that referenced
this issue
Oct 11, 2023
…e monorepo - See #1718 - See MetaMask/eth-json-rpc-provider#27 - Closes #1682
MajorLift
added a commit
that referenced
this issue
Oct 11, 2023
…of migration (#28) ## Description - This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo. - This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo. - Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo. ## References - See #1551 - Closes #1683 - Closes #1682 (is superseded by this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to be able to migrate the
@metamask/eth-json-rpc-providerpackage into the core monorepo, the typescript versions of the packages should match.@metamask/eth-json-rpc-provideris currently usingtypescriptwith version~4.8.4. We should use version~4.6.3.The text was updated successfully, but these errors were encountered: