-
-
Notifications
You must be signed in to change notification settings - Fork 256
Closed
Labels
enhancementNew feature or requestNew feature or requestteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.
Description
Motivation
We need a standardized, automated way of porting tags for libraries migrated into merged-packages/ that satisfies the following:
- Distinguishes between releases of the monorepo root vs. non-root subpackages by prepending a package name prefix to all tag names of libraries that are migrated into the monorepo.
- monorepo root release tags:
v<maj>.<min>.<patch> - non-root subpackage release tags:
@metamask/<package-name>@<maj>.<min>.<patch>
- Ensures that tag diff links in the target package's CHANGELOG correctly point to valid tags in core after migration.
- e.g.
https://github.com/MetaMask/core/compare/@metamask/<package-name>@<maj>.<min>.<patch>...@metamask/<package-name>@<maj>.<min>.<patch>
Considerations
- If the target library was renamed at any point, the tag name prefixes should display the correct original package name that corresponds to the tag version.
- The release commit hashes in the rewritten git history in core will not match the hashes for the tagged commits in the original repo.
Process
- Find the new hashes for the release commits from the migrated commit history of the target package directory in
merged-packages/. - Identify tags where the package was renamed.
- Map each version number and package name onto the corresponding release commit hash.
- Add the tags by running
git tag <tag-name> [commit-hash]for each tag-commit pair with the correct package name prepended onto the tag name.
Blocked by
References
- See Fully migrate
eth-json-rpc-providerinto core monorepo #1551 (comment) for an outline of the migration process. - See Migrate libraries into core monorepo #1079 (comment) for instructions on migrating the git history of the original repo.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.