Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets-controllers: Replace use of any with proper types (non-test files only) #3714

Closed
Tracked by #3706
mcmire opened this issue Jan 4, 2024 · 2 comments · Fixed by #3818
Closed
Tracked by #3706

assets-controllers: Replace use of any with proper types (non-test files only) #3714

mcmire opened this issue Jan 4, 2024 · 2 comments · Fixed by #3818
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Jan 4, 2024

Look for the following string in non-test files to find these: // TODO: Replace `any` with type

At time of writing, there were 11 instances.

@desi
Copy link
Contributor

desi commented Jan 18, 2024

Hey team! Please add your planning poker estimate with Zenhub @Gudahtt @mcmire @MajorLift @kanthesha

@Gudahtt
Copy link
Member

Gudahtt commented Jan 18, 2024

Of the 11 any instances, 4 are our provider, and 4 are just catch block errors that need type guards. Not sure about the other 3.

kanthesha added a commit that referenced this issue Feb 9, 2024
…pes (#3818)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

Replace use of `any` with proper types (non-test files only) in
asset-controller.

## References

<!--
Are there any issues that this pull request is tied to? Are there other
links that reviewers should consult to understand these changes better?

For example:

* Fixes #12345
* Related to #67890
-->

* Fixes #3714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants