Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polling-controller: Replace use of any with proper types (non-test files only) #3728

Closed
Tracked by #3706
mcmire opened this issue Jan 4, 2024 · 0 comments · Fixed by #4042
Closed
Tracked by #3706

polling-controller: Replace use of any with proper types (non-test files only) #3728

mcmire opened this issue Jan 4, 2024 · 0 comments · Fixed by #4042
Assignees
@MajorLift
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Jan 4, 2024 •
edited
Loading

Look for the following string in non-test files to find these: // TODO: Replace `any` with type

At time of writing, there were 3 instances.
@mcmire mcmire mentioned this issue Jan 4, 2024
Open
19 tasks
@MajorLift MajorLift self-assigned this Mar 10, 2024
@MajorLift MajorLift mentioned this issue Mar 11, 2024
Merged
3 tasks
MajorLift added a commit that referenced this issue Mar 13, 2024
@MajorLift
[polling-controller] minor type refactors (#4042)
304d19b 
## Explanation

- Consolidate types into 'types' module.
- Add comment explaining that `any` is required by the compiler for
mixin constructors.

## References

- Closes #3728

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[polling-controller] minor type refactors MetaMask/core
2 participants
@mcmire @MajorLift