feat: Update PreferencesController with tokenNetworkFilter
#4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
| @@ -128,6 +128,10 @@ export type PreferencesState = { | |||
| * Controls which order tokens are sorted in | |||
| */ | |||
| tokenSortConfig: TokenSortConfig; | |||
| /** | |||
| * Controls which order tokens are sorted in | |||
There was a problem hiding this comment.
this jsdoc doesn't seem to be correct and a copy of the one above it ?
|
@gambinish, could you please add some unit tests? You can use as an example how the other preferences are tested for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds tokenNetworkFilter setting. Required for: MetaMask/metamask-mobile#11808
References
MetaMask/metamask-mobile#11808
Changelog
Adds
tokenNetworkFilterwith a default value of{}typeRecord<string, boolean>@metamask/preferences-controllerChecklist