Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Token Network Filter UI [Mobile] #11808

Merged
merged 145 commits into from
Nov 12, 2024
Merged

feat: Token Network Filter UI [Mobile] #11808

merged 145 commits into from
Nov 12, 2024
+390 −43

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Oct 16, 2024 •
edited
Loading

Description

This PR introduces token network filter UI component. It lives behind a feature flag PORTFOLIO_VIEW in order to allow this to get merged while backend changes are in flight.

Integration with the multichain asset list will occur in a separate PR. We'll likely want to add additional e2e tests when that happens.

Running this branch

yarn && yarn setup
PORTFOLIO_VIEW=1 yarn watch
yarn start:ios or i from the watch process

Please ensure that this PR looks okay both with and without the feature flag running. I have introduced a horizontal scroll view because there simply was not enough screen real estate to make the network filter look okay with truncated text.

Related issues

Fixes:

Manual testing steps

  1. Run app with feature flag
  2. Go to main Portfolio view
  3. Pressing the network filter should trigger the bottom sheet, allowing the user to select different filter options.

Screenshots/Recordings

Screen.Recording.2024-10-29.at.1.25.18.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

gambinish and others added 30 commits September 26, 2024 17:09
@gambinish
feat: Add sortAssets utility function
0248c74
@gambinish
chore: Breakup monolithic Tokens/index.tsx into smaller components
6a2e8c7
@gambinish
fix: Correctly handle null check for buyable footer button
7a78717
@gambinish
fix: Tweak boolean logic for rendering footer components
57295ee
@gambinish
chore: Update snapshot
d00354f
@gambinish
chore: Type out tokens as TokenI[]
be87f81
@gambinish
chore: Remove unecessary comments around import statements in Networt…
68c7b2e 
…h component
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
a02e139
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
de5bbed
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
0fd9ad5
@gambinish
chore: Add unit tests to utility file, provide exports from index file
032618c
@gambinish
chore: Rename handleBalance to me more descriptive of what its logic …
a58f1ba 
…is handling
@gambinish
chore: rename Networth to PortfolioBalance for clarity
1dd31e3
@gambinish
chore: Cleanup styles extra whitespace
16ded6a
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
52d3d85
@gambinish
fix: Update snapshot tests
dd3ffdf
@gambinish
Merge branch 'chore/componetize-tokens-screen' of github.com:MetaMask…
da640bc 
…/metamask-mobile into chore/componetize-tokens-screen
@gambinish
fix: Remove unused component
ebcbcf6
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
31fad19
@gambinish
chore: Move PotfolioBalance above TabView
4a8d927
@gambinish
fix: Wrap PortfolioBalance and ScrollableView in fragment for token r…
a7b4c17 
…endering
@gambinish
fix: Padding tweak below tab bar for consistency of token list
658fcf6
@gambinish
fix: Reorganize test suite for PortfolioBalance
18035d4
@gambinish
fix: Revert changes to wallet test
c570c2c
@gambinish
fix: Update fiatBalance text style to DisplayMD
a97128b
@gambinish
chore: Patch PreferencesController with tokenSortConfig
8036a0a
@gambinish
chore: Patch preferences controller with type
1f0ac51
@gambinish
feat: Build token sorting UI, patch PreferencesController
34d987c
@gambinish
chore: Merge main, address merge conflicts
d57558b
@gambinish
fix: ListHeaderComponent not needed in FlatList anymore
c5c954c
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8959d19
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/14be83e2-968e-4d00-a4fc-f6db6b114a47

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8959d19
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/14be83e2-968e-4d00-a4fc-f6db6b114a47

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

sethkfman and others added 2 commits November 12, 2024 19:58
@sethkfman @runway-github
@metamaskbot @tommasini @github-actions @dawnseeker8 @NicolasMassart @NicholasEllul @legobeat @OGPoyraz @salimtb @wachunei @bfullam @elefantel @Kaihuang72490 @Cal-L @sahar-fehri @vinnyhoward @matthewwalsh0
feat: 7.34.0 (#11858)
2ce9b47 
This is the release candidate for version 7.34.0
 
  # Team sign-off checklist
  - [ ] team-accounts
  - [ ] team-assets
  - [x] team-confirmations
  - [x] team-design-system
  - [ ] team-lavamoat
  - [x] team-mobile-platform 
  - [x] team-notifications
  - [x] team-ramp
  - [ ] team-sdk
  - [ ] team-security
  - [x] team-snaps-platform 
  - [x] team-stake
  - [ ] team-tiger
  - [ ] team-wallet-framework
  - [ ] team-wallet-ux


  # Reference
- Testing plan sheet -
https://docs.google.com/spreadsheets/d/1tsoodlAlyvEUpkkcNcbZ4PM9HuC9cEM80RZeoVv5OCQ/edit?gid=404070372#gid=404070372

---------

Signed-off-by: Kai Huang <kai.huang@consensys.net>
Co-authored-by: runway-github[bot] <73448015+runway-github[bot]@users.noreply.github.com>
Co-authored-by: MetaMask Bot <37885440+metamaskbot@users.noreply.github.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Xiaoming Wang <7315988+dawnseeker8@users.noreply.github.com>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Co-authored-by: Xiaoming Wang <dawnseeker8@gmail.com>
Co-authored-by: Nicholas Ellul <nicholas.ellul1@gmail.com>
Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com>
Co-authored-by: Salim TOUBAL <salim.toubal@outlook.com>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: tommasini <tommasini15@gmail.com>
Co-authored-by: Bryan Fullam <bryanfullam@gmail.com>
Co-authored-by: Mpendulo Ndlovu <mpendulo@elefantel.com>
Co-authored-by: Kaihuang72490 <147628638+Kaihuang72490@users.noreply.github.com>
Co-authored-by: Cal-L <cleun007@gmail.com>
Co-authored-by: Cal Leung <cal.leung@consensys.net>
Co-authored-by: sahar-fehri <sahar.fehri@consensys.net>
Co-authored-by: Vince Howard <vincenguyenhoward@gmail.com>
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
@gambinish
Merge branch 'main' into feat/mmassets-431_network-filter-ui
496126b
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9e6a0a5-3c3c-4e50-9dbe-bbe25db212ff

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9e6a0a5-3c3c-4e50-9dbe-bbe25db212ff

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit de05544 Nov 12, 2024
48 of 49 checks passed
@gambinish gambinish deleted the feat/mmassets-431_network-filter-ui branch November 12, 2024 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

8 similar comments
@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 496126b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e0acf3f-9a17-4b5e-a517-6de778c0dd07

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@Cal-L Cal-L Cal-L approved these changes

@darkwing darkwing darkwing approved these changes

@vinnyhoward vinnyhoward vinnyhoward left review comments

@brianacnguyen brianacnguyen brianacnguyen left review comments

@jonybur jonybur Awaiting requested review from jonybur

@salimtb salimtb Awaiting requested review from salimtb

Assignees
No one assigned
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gambinish @codecov-commenter @metamaskbot @darkwing @Cal-L @brianacnguyen @salimtb @vinnyhoward @NidhiKJha @sethkfman