-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 49.0.0 #1263
Release 49.0.0 #1263
Conversation
222c6f7
to
408e833
Compare
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
The breaking change in the network controller is also effectively a breaking change for any package that has the network controller as a peer dependency ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Lots of changes in this release, the network controller especially has been in need of a release for some time.
I have finished reviewing these changes, and can approve once all of my comments have been addressed. The last thing I have left to do is review the network controller changelog to see if I can add further detail to explain which changes are breaking, and how to accommodate them when updating. I can revise the changelog post-merge with those changes if necessary though, so it doesn't need to block
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished making suggestions for the network controller changelog
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Updated according to your great feedback @Gudahtt |
021eaa7
to
4e12d52
Compare
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM, but would appreciate @Gudahtt sign off too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Release 49.0.0 * Updated changelogs --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com> Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
* Release 49.0.0 * Updated changelogs --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com> Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Description
Release outstanding changes before bump to nodejs v16.
Changes
approval-controller
controller-utils
ens-controller
keyring-controller
message-manager
network-controller
rollbackToPreviousProvider
async (MakerollbackToPreviousProvider
async #1237)resetConnection
async (MakeresetConnection
async #1239)setProviderType
unit tests (SimplifysetProviderType
unit tests #1222)setProviderType
unit tests (ConsolidatesetProviderType
unit tests #1221)isCustomNetwork
(RemoveisCustomNetwork
#1199)network
state withnetworkId
andnetworkStatus
(Replacenetwork
state withnetworkId
andnetworkStatus
#1196)upsertNetworkConfiguration
async (MakeupsertNetworkConfiguration
async #1192)setActiveNetwork
async (MakesetActiveNetwork
async #1190)setProviderType
async (MakesetProviderType
async #1191)refreshNetwork
async (MakerefreshNetwork
async #1182)initializeProvider
async (MakeinitializeProvider
async #1180)verifyNetwork
async (MakeverifyNetwork
async #1181)permission-controller
SubjectMetadataController
to permission-controller package (BREAKING: MoveSubjectMetadataController
to permission-controller package #1234)rate-limit-controller
transaction-controller
isCustomNetwork
(RemoveisCustomNetwork
#1199)network
state withnetworkId
andnetworkStatus
(Replacenetwork
state withnetworkId
andnetworkStatus
#1196)References
#1262