Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 49.0.0 #1263

Merged
merged 28 commits into from
Apr 26, 2023
Merged

Release 49.0.0 #1263

merged 28 commits into from
Apr 26, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 25, 2023

Description

Release outstanding changes before bump to nodejs v16.

Changes

approval-controller

controller-utils

ens-controller

keyring-controller

message-manager

network-controller

permission-controller

rate-limit-controller

transaction-controller

References

#1262

@legobeat legobeat marked this pull request as ready for review April 25, 2023 11:38
@legobeat legobeat requested a review from a team as a code owner April 25, 2023 11:38
OGPoyraz
OGPoyraz previously approved these changes Apr 25, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
legobeat and others added 2 commits April 25, 2023 21:39
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@Gudahtt
Copy link
Member

Gudahtt commented Apr 25, 2023

The breaking change in the network controller is also effectively a breaking change for any package that has the network controller as a peer dependency (assets-controllers and gas-fee-controller). We should add an entry to those two package changelogs about this as well, and ensure it's marked as **BREAKING:** with a major version bump.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Lots of changes in this release, the network controller especially has been in need of a release for some time.

I have finished reviewing these changes, and can approve once all of my comments have been addressed. The last thing I have left to do is review the network controller changelog to see if I can add further detail to explain which changes are breaking, and how to accommodate them when updating. I can revise the changelog post-merge with those changes if necessary though, so it doesn't need to block

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished making suggestions for the network controller changelog

legobeat and others added 2 commits April 26, 2023 07:37
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@legobeat

This comment was marked as outdated.

@legobeat legobeat requested review from Gudahtt and OGPoyraz April 26, 2023 09:36
@legobeat
Copy link
Contributor Author

Updated according to your great feedback @Gudahtt

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, but would appreciate @Gudahtt sign off too

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 4cf5dbe into main Apr 26, 2023
@Gudahtt Gudahtt deleted the release/49.0.0 branch April 26, 2023 11:40
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Release 49.0.0

* Updated changelogs

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Release 49.0.0

* Updated changelogs

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com>
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants