TransactionController #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
======================================
Coverage 100% 100%
======================================
Files 13 14 +1
Lines 431 612 +181
Branches 50 74 +24
======================================
+ Hits 431 612 +181
Continue to review full report at Codecov.
|
mcmire
referenced
this pull request
in mcmire/core
Jul 17, 2023
* Add JSON storage limit utilities * Add handling for string length depending on encoding * Add handling for number sizes * Refactor code and add more tests * Add functional code improvements and tests * Add edge case handling and more complex tests * Refactor code, change approaches and improve tests * Minor code refactoring and additional test * Add one more unit test * Refactor tests and test data * Add skip feature for JSON size calculation * Add algorithm improvements and new test data * Minor refactoring of calculateStringSize function * Minor refactoring of isASCII function * Minor refactoring of skip sizing feature * Add unit tests for circular structures * Add test improvement with escape characters * Code refactoring * Code refactoring & improvements * Small code refactoring (review answer) * Another minor code refactoring (review answer) * Remove useless comment * Add more tests for serialization checks of functions and symbols * Add specific approach for handling Date objects * Add ECMA TC39 (test262) test scenarios and improve algorithm * Add another batch of ECMA TC39 (test262) test scenarios * Fix types in tests * Add optimized check for circular structures * Change approach for circular object detection * Improve circular object detection * Improve Date object sizing * Change type-check approach (if-else) * Add explanation comments for circular structure detection and improve tests
kanthesha
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Fix package.json, CI config
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
* serialize errors using eth-json-rpc-errors * add .nvmrc * remove dead code
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix package.json, CI config
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix package.json, CI config
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Fix package.json, CI config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does the following:
BlockHistoryController#getLatestBlockBaseController#requiredControllers