Add EnsController #151
Merged
Add EnsController #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #151 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 22 +1
Lines 1439 1484 +45
Branches 193 206 +13
======================================
+ Hits 1439 1484 +45
Continue to review full report at Codecov.
|
5 tasks
jennypollack
reviewed
Sep 1, 2019
jennypollack
reviewed
Sep 1, 2019
rekmarks
force-pushed
the
ens-controller
branch
from
b18139e to
d57c54b
Compare
rekmarks
force-pushed
the
ens-controller
branch
from
f9a2382 to
4cc0b37
Compare
rekmarks
force-pushed
the
ens-controller
branch
from
4cc0b37 to
0ba246a
Compare
jennypollack
approved these changes
Sep 10, 2019
2 tasks
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
add EnsController and tests use ENS name normalization in address book
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
add EnsController and tests use ENS name normalization in address book
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
EnsController. It keeps track of ENS name and their resolved addresses for the purpose of taking some useful action (e.g. warning the user in the UI).Addresses and ENS names (see
util.ts:normalizeEnsName) are normalized before being added. ENS name normalization added to address book controller as well.ENS name normalization and verification should be updated in the extension if this change is integrated. That should amount to importing
normalizeEnsNamefromsrc/util.ts.