Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: nonce-tracker@^1.1.0->^3.0.0 #2040

Merged
merged 6 commits into from
Nov 17, 2023
Merged

deps: nonce-tracker@^1.1.0->^3.0.0 #2040

merged 6 commits into from
Nov 17, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 15, 2023 •
edited
Loading

Explanation

Context: #1859 (comment)

[3.0.0]

Added

  • Add ancillary types (#53)

Changed

  • BREAKING: Drop support for Node.js v14; minimum required version is now v16 (#54)
  • Move NonceTracker to named export instead of default (#53)

[2.0.0]

Changed

  • BREAKING: Switched from ethjs-query to @ethersproject/providers (#39)
  • BREAKING: Minimum Node.js version is now 14 (#42)

References

Changelog

@metamask/transaction-controller

  • Changed: Bump nonce-tracker from ^1.0.0 to ^3.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security Socket Security
Copy link

socket-security bot commented Nov 15, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
nonce-tracker 1.1.0...3.0.0 None +2/-10 124 kB metamaskbot

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Nov 15, 2023
@legobeat legobeat marked this pull request as ready for review November 15, 2023 09:23
@legobeat legobeat requested a review from a team as a code owner November 15, 2023 09:23
@legobeat legobeat force-pushed the nonce-tracker-3 branch 2 times, most recently from 8bf3977 to 8ba2c08 Compare November 15, 2023 10:10
@legobeat
chore(constraints): remove required peerDependency for nonce-tracker
1a111e6 
nonce-tracker no longer depends on ethjs-query so the corresponding yarn
constraint can be removed
mcmire
mcmire reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Just one question and then I'm good.

constraints.pro Show resolved Hide resolved
packages/transaction-controller/src/TransactionController.ts Show resolved Hide resolved
@legobeat legobeat requested a review from mcmire November 15, 2023 19:20
mcmire
mcmire approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@legobeat legobeat merged commit b47aec4 into MetaMask:main Nov 17, 2023
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@OGPoyraz OGPoyraz Awaiting requested review from OGPoyraz

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0

@vinistevam vinistevam Awaiting requested review from vinistevam

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire