Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ethereumjs-wallet from v0.6.5 to v1.0.1 #347

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 11, 2021

ethereumjs-wallet was migrated to TypeScript in v1, so this update brings types with it. There were various API changes as well, which have all been accounted for.

`ethereumjs-wallet` was migrated to TypeScript in v1, so this update
brings types with it. There were various API changes as well [1], which
have all been accounted for.

[1]: https://github.com/ethereumjs/ethereumjs-wallet/releases/tag/v1.0.0
@Gudahtt Gudahtt requested a review from a team as a code owner February 11, 2021 15:29
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gudahtt Gudahtt merged commit 06fd4ee into develop Feb 11, 2021
@Gudahtt Gudahtt deleted the update-ethereumjs-wallet branch February 11, 2021 16:01
rickycodes added a commit that referenced this pull request Feb 18, 2021
…ba into feature/migrate-to-etherscan

* 'feature/migrate-to-etherscan' of github.com:MetaMask/gaba:
  Update `sinon` and `@types/sinon` to latest versions (#352)
  Fix `tsconfig.json` indentation (#355)
  Replace `fetch-mock` with `nock` (#340)
  Update `ethereumjs-wallet` from v0.6.5 to v1.0.1 (#347)
  Add `babel-runtime` dependency required by `ethjs-query` (#341)
  Update `@metamask/eslint-config` from v3 to v4.1.0 (#344)
  Add `docs` to list of ignored eslint patterns (#345)
  Update `uuid` from `v3.3.3` to `v8.3.2` (#346)
  Update approval controller test import (#339)
  Add Dependabot config (#343)
  Update `typedoc` (#342)
  Remove unused test module (#338)
  Replace `await-semaphore` with `async-mutex` (#334)
  Update `eth-json-rpc-filters` in lockfile (#336)
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
`ethereumjs-wallet` was migrated to TypeScript in v1, so this update
brings types with it. There were various API changes as well [1], which
have all been accounted for.

[1]: https://github.com/ethereumjs/ethereumjs-wallet/releases/tag/v1.0.0
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
`ethereumjs-wallet` was migrated to TypeScript in v1, so this update
brings types with it. There were various API changes as well [1], which
have all been accounted for.

[1]: https://github.com/ethereumjs/ethereumjs-wallet/releases/tag/v1.0.0
mikesposito added a commit that referenced this pull request Dec 6, 2024
…5037)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->
Bumping `@metamask/eth-json-rpc-middleware` from `^15.0.0` to `^15.0.1`
```
### Changed
- Bump `@metamask/eth-block-tracker` from `^11.0.1` to `^11.0.3` ([#347](MetaMask/eth-json-rpc-middleware#347))
```

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->
* Related to MetaMask/metamask-extension#17040

## Changelog

<!--
If you're making any consumer-facing changes, list those changes here as
if you were updating a changelog, using the template below as a guide.

(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
FIXED. For security-related issues, follow the Security Advisory
process.)

Please take care to name the exact pieces of the API you've added or
changed (e.g. types, interfaces, functions, or methods).

If there are any breaking changes, make sure to offer a solution for
consumers to follow once they upgrade to the changes.

Finally, if you're only making changes to development scripts or tests,
you may replace the template below with "None".
-->

### `@metamask/network-controller`

- **CHANGED**: Bump `@metamask/eth-json-rpc-middleware` from `^15.0.0`
to `^15.0.1`


## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
shane-t pushed a commit that referenced this pull request Dec 6, 2024
…5037)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->
Bumping `@metamask/eth-json-rpc-middleware` from `^15.0.0` to `^15.0.1`
```
### Changed
- Bump `@metamask/eth-block-tracker` from `^11.0.1` to `^11.0.3` ([#347](MetaMask/eth-json-rpc-middleware#347))
```

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->
* Related to MetaMask/metamask-extension#17040

## Changelog

<!--
If you're making any consumer-facing changes, list those changes here as
if you were updating a changelog, using the template below as a guide.

(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
FIXED. For security-related issues, follow the Security Advisory
process.)

Please take care to name the exact pieces of the API you've added or
changed (e.g. types, interfaces, functions, or methods).

If there are any breaking changes, make sure to offer a solution for
consumers to follow once they upgrade to the changes.

Finally, if you're only making changes to development scripts or tests,
you may replace the template below with "None".
-->

### `@metamask/network-controller`

- **CHANGED**: Bump `@metamask/eth-json-rpc-middleware` from `^15.0.0`
to `^15.0.1`


## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants