Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ComposableController to extend BaseControllerV2 #3590

Merged
merged 16 commits into from
Dec 11, 2023
Merged

Upgrade ComposableController to extend BaseControllerV2 #3590

merged 16 commits into from
Dec 11, 2023

Commits on Dec 1, 2023

  1. Define ControllerInstance type

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    63c29fb View commit details
    Browse the repository at this point in the history

  2. Define types required by BaseControllerV2

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    1e79aee View commit details
    Browse the repository at this point in the history

  3. Extract #updateChildController method

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d7d6065 View commit details
    Browse the repository at this point in the history

  4. Upgrade ComposableController to BaseControllerV2

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    729f027 View commit details
    Browse the repository at this point in the history

  5. Supress type error in test for missing messenger param

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    84d96e1 View commit details
    Browse the repository at this point in the history

  6. Fix tests to align with upgraded ComposableController API

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7cd88fb View commit details
    Browse the repository at this point in the history

  7. Omit inferrable generic params in .getRestricted() calls

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4c42fe9 View commit details
    Browse the repository at this point in the history

  8. Add JSDoc for constructor params

    @MajorLift
    MajorLift committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    1959df1 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Apply review suggestions 

    Co-authored-by: Ellilot Winkler <elliot.winkler@gmail.com>
    @MajorLift @mcmire
    MajorLift and mcmire committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    65839dc View commit details
    Browse the repository at this point in the history

  2. Rewrite BaseControllerV1 assertion logic to use instanceOf, remov… 

    …e`BaseControllerV2.subscribe` field
    @MajorLift
    MajorLift committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    63d5d06 View commit details
    Browse the repository at this point in the history

  3. Always require messenger in constructor 

    - No other way to handle `super({ messenger })` call now that `ComposableController` extends from `BaseControllerV2`
    @MajorLift
    MajorLift committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    ac750ec View commit details
    Browse the repository at this point in the history

  4. Remove ComposableController{GetStateAction,Actions}

    @MajorLift
    MajorLift committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1ddf33c View commit details
    Browse the repository at this point in the history

  5. Explicitly enumerate package-level exports

    @MajorLift
    MajorLift committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    cdfe540 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Record CHANGELOG entries

    @MajorLift
    MajorLift committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    55ed686 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge branch 'main' into 231128-upgrade-ComposableController-to-BaseC… 

    …ontrollerV2
    @MajorLift
    MajorLift committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3d8a220 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'main' into 231128-upgrade-ComposableController-to-BaseC… 

    …ontrollerV2
    @MajorLift
    MajorLift authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    330a4da View commit details
    Browse the repository at this point in the history