-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade TokenDetectionController
to extend BaseControllerV2
, StaticIntervalPollingController
#3609
Upgrade TokenDetectionController
to extend BaseControllerV2
, StaticIntervalPollingController
#3609
Commits on Dec 11, 2023
-
Define types for BaseControllerV2 migration
- Add types`TokenDetectionState`, `TokenDetectionControllerGetStateAction`, `TokenDetectionControllerActions`, `TokenDetectionControllerStateChangeEvent`, `TokenDetectionControllerEvents`, `TokenDetectionControllerMessenger`
Configuration menu - View commit details
-
Copy full SHA for d595d0f - Browse repository at this point
Copy the full SHA d595d0fView commit details -
Upgrade
TokenDetectionController
to extend fromPollingController
- Remove methods that can be replaced with actions/events - Replace references to `this.config` with `this.state` - Replace `this.configure()` calls with `this.update()`
Configuration menu - View commit details
-
Copy full SHA for 56ca692 - Browse repository at this point
Copy the full SHA 56ca692View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ae501 - Browse repository at this point
Copy the full SHA 25ae501View commit details -
[token-list-controller] Export
TokenListControllerMessenger
and def……ine `AllowedEvents`
Configuration menu - View commit details
-
Copy full SHA for d42cc0f - Browse repository at this point
Copy the full SHA d42cc0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a66c50 - Browse repository at this point
Copy the full SHA 0a66c50View commit details -
Move
TokenDetectionConfig
properties to private class fields in `To……kenDetectionController`
Configuration menu - View commit details
-
Copy full SHA for 1b5b635 - Browse repository at this point
Copy the full SHA 1b5b635View commit details -
Define
controllerName
,TokenDetectionState
as empty object, remov……e `getNetworkState`
Configuration menu - View commit details
-
Copy full SHA for 94448cd - Browse repository at this point
Copy the full SHA 94448cdView commit details -
Fix: unregister internal
getState
action handler in constructor as ……state object is not used
Configuration menu - View commit details
-
Copy full SHA for bcfa0a1 - Browse repository at this point
Copy the full SHA bcfa0a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8dcf32 - Browse repository at this point
Copy the full SHA b8dcf32View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5ef650 - Browse repository at this point
Copy the full SHA a5ef650View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72b3618 - Browse repository at this point
Copy the full SHA 72b3618View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f74472 - Browse repository at this point
Copy the full SHA 2f74472View commit details -
Assume that
getTokensState
never returnsundefined
- Will throw runtime error if `getTokensState` doesn't return valid tokens state: ``` TypeError: Cannot destructure property 'tokens' of '((cov_1sp0cd8ows(...).s[79]++) , __classPrivateFieldGet(...).call(...))' as it is undefined. ```
Configuration menu - View commit details
-
Copy full SHA for 720dc69 - Browse repository at this point
Copy the full SHA 720dc69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74f74ba - Browse repository at this point
Copy the full SHA 74f74baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b3d4e4 - Browse repository at this point
Copy the full SHA 7b3d4e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bef9b8 - Browse repository at this point
Copy the full SHA 2bef9b8View commit details -
Use new network-controller action/event
- Replace `NetworkControlerGetNetworkClientByIdAction` with `NetworkCotnrollerGetNetworkConfigurationByNetworkClientId` - Use `NetworkControllerNetworkDidChangeEvent`
Configuration menu - View commit details
-
Copy full SHA for 9c8491a - Browse repository at this point
Copy the full SHA 9c8491aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05ed86b - Browse repository at this point
Copy the full SHA 05ed86bView commit details -
Move
unregisterActionhandler
calls for `TokenDetectionController:ge……tState` to before `super` call in constructor
Configuration menu - View commit details
-
Copy full SHA for 8964e0d - Browse repository at this point
Copy the full SHA 8964e0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26509c1 - Browse repository at this point
Copy the full SHA 26509c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb2bd08 - Browse repository at this point
Copy the full SHA cb2bd08View commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9244803 - Browse repository at this point
Copy the full SHA 9244803View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1274137 - Browse repository at this point
Copy the full SHA 1274137View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c0476c - Browse repository at this point
Copy the full SHA 0c0476cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dc1fcd - Browse repository at this point
Copy the full SHA 8dc1fcdView commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for bb43ebb - Browse repository at this point
Copy the full SHA bb43ebbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdb70d9 - Browse repository at this point
Copy the full SHA fdb70d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98e8d17 - Browse repository at this point
Copy the full SHA 98e8d17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ad12b5 - Browse repository at this point
Copy the full SHA 8ad12b5View commit details -
Fix
#getCorrectChainId
and polygon network test to pull network con……fig for current `chainId` value if `networkClientId` is not provided
Configuration menu - View commit details
-
Copy full SHA for 5e94d13 - Browse repository at this point
Copy the full SHA 5e94d13View commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for a5ebc52 - Browse repository at this point
Copy the full SHA a5ebc52View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2007f6 - Browse repository at this point
Copy the full SHA a2007f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3532bbc - Browse repository at this point
Copy the full SHA 3532bbcView commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for 6601dcc - Browse repository at this point
Copy the full SHA 6601dccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 322d074 - Browse repository at this point
Copy the full SHA 322d074View commit details -
Configuration menu - View commit details
-
Copy full SHA for b60ada5 - Browse repository at this point
Copy the full SHA b60ada5View commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for 599da4d - Browse repository at this point
Copy the full SHA 599da4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c22a3a - Browse repository at this point
Copy the full SHA 6c22a3aView commit details
Commits on Dec 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a26d568 - Browse repository at this point
Copy the full SHA a26d568View commit details -
Remove unregister action handler call in constructor and define `befo…
…reEach` for `getBalancesInSingleCall` tests
Configuration menu - View commit details
-
Copy full SHA for 85e3f10 - Browse repository at this point
Copy the full SHA 85e3f10View commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for e1a061a - Browse repository at this point
Copy the full SHA e1a061aView commit details -
Revert "Fix
sliceOfTokensToDetect
logic to handle arbitrary number ……of `tokensToDetect`" This reverts commit b8dcf32.
Configuration menu - View commit details
-
Copy full SHA for b9cbcba - Browse repository at this point
Copy the full SHA b9cbcbaView commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for 4322102 - Browse repository at this point
Copy the full SHA 4322102View commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fb7cbe2 - Browse repository at this point
Copy the full SHA fb7cbe2View commit details -
Fix test so that
preferencesStateChangeListener
triggers `detectTok……ens` without `.start()` call
Configuration menu - View commit details
-
Copy full SHA for 5d602a3 - Browse repository at this point
Copy the full SHA 5d602a3View commit details -
Add
#networkClientId
class field and update using `seletedNetworkCl……ientId` in `networkDidChange` listener
Configuration menu - View commit details
-
Copy full SHA for a41a218 - Browse repository at this point
Copy the full SHA a41a218View commit details -
Update CHANGELOG to reflect 'Revert "Fix
sliceOfTokensToDetect
logi……c to handle arbitrary number of `tokensToDetect`'
Configuration menu - View commit details
-
Copy full SHA for 7e52c7c - Browse repository at this point
Copy the full SHA 7e52c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7dac31 - Browse repository at this point
Copy the full SHA e7dac31View commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for 15f8922 - Browse repository at this point
Copy the full SHA 15f8922View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15ea19c - Browse repository at this point
Copy the full SHA 15ea19cView commit details -
Revert "Add
#networkClientId
class field and update using `seletedN……etworkClientId` in `networkDidChange` listener" This reverts commit a41a218.
Configuration menu - View commit details
-
Copy full SHA for 3e1416d - Browse repository at this point
Copy the full SHA 3e1416dView commit details -
Revert "Fix test so that
preferencesStateChangeListener
triggers `d……etectTokens` without `.start()` call" This reverts commit 5d602a3.
Configuration menu - View commit details
-
Copy full SHA for 123aff5 - Browse repository at this point
Copy the full SHA 123aff5View commit details -
Fix test so that
preferencesStateChangeListener
triggers `detectTok……ens` without `.start()` call
Configuration menu - View commit details
-
Copy full SHA for 7f2e58b - Browse repository at this point
Copy the full SHA 7f2e58bView commit details -
Add
#networkClientId
class field and update using `seletedNetworkCl……ientId` in `networkDidChange` listener - add `NetworkControllerFindNetworkClientIdByChainId` as allowed action
Configuration menu - View commit details
-
Copy full SHA for d32cdf4 - Browse repository at this point
Copy the full SHA d32cdf4View commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for 9167cac - Browse repository at this point
Copy the full SHA 9167cacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71d9967 - Browse repository at this point
Copy the full SHA 71d9967View commit details -
Add
#disabled
class field to ensure that passive token detection is…… blocked by `stop()` call, and only restored by `start(0` call
Configuration menu - View commit details
-
Copy full SHA for 0dda603 - Browse repository at this point
Copy the full SHA 0dda603View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5eec25 - Browse repository at this point
Copy the full SHA c5eec25View commit details
Commits on Dec 15, 2023
-
Update packages/assets-controllers/src/TokenDetectionController.test.ts
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1337d19 - Browse repository at this point
Copy the full SHA 1337d19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41f85a1 - Browse repository at this point
Copy the full SHA 41f85a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c331fa - Browse repository at this point
Copy the full SHA 8c331faView commit details -
Configuration menu - View commit details
-
Copy full SHA for d40247e - Browse repository at this point
Copy the full SHA d40247eView commit details -
[tokens-controller] Add actions
getState
,addDetectedTokens
and e……vent `stateChange`
Configuration menu - View commit details
-
Copy full SHA for 757ab04 - Browse repository at this point
Copy the full SHA 757ab04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44e92cb - Browse repository at this point
Copy the full SHA 44e92cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b0bda3 - Browse repository at this point
Copy the full SHA 4b0bda3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a007d15 - Browse repository at this point
Copy the full SHA a007d15View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5e6611 - Browse repository at this point
Copy the full SHA f5e6611View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2a5af5 - Browse repository at this point
Copy the full SHA b2a5af5View commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for eadf3ba - Browse repository at this point
Copy the full SHA eadf3baView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa9e3ba - Browse repository at this point
Copy the full SHA aa9e3baView commit details -
Revert "Fix incorrect package-level export"
This reverts commit d40247e.
Configuration menu - View commit details
-
Copy full SHA for f636e25 - Browse repository at this point
Copy the full SHA f636e25View commit details
Commits on Dec 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 173168f - Browse repository at this point
Copy the full SHA 173168fView commit details -
Replace
chainId
withnetworkClientId
in constructor options.- Derive `chainId` from `networkClientId` using `#getCorrectChainId` method
Configuration menu - View commit details
-
Copy full SHA for d81c23d - Browse repository at this point
Copy the full SHA d81c23dView commit details
Commits on Dec 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d9bd4b1 - Browse repository at this point
Copy the full SHA d9bd4b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fefc64b - Browse repository at this point
Copy the full SHA fefc64bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73eccbf - Browse repository at this point
Copy the full SHA 73eccbfView commit details -
Add
disabled
as constructor option and set it to block `#startPolli……ng`, `_executePoll`, `_startPollingByNetworkClientId` calls
Configuration menu - View commit details
-
Copy full SHA for 5fe7674 - Browse repository at this point
Copy the full SHA 5fe7674View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 116a227 - Browse repository at this point
Copy the full SHA 116a227View commit details
Commits on Dec 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for acd022f - Browse repository at this point
Copy the full SHA acd022fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee2154d - Browse repository at this point
Copy the full SHA ee2154dView commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for cfbd787 - Browse repository at this point
Copy the full SHA cfbd787View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21f9b8c - Browse repository at this point
Copy the full SHA 21f9b8cView commit details -
Revert "[tokens-controller] Add actions
getState
, `addDetectedToken……s` and event `stateChange`" This reverts commit 757ab04.
Configuration menu - View commit details
-
Copy full SHA for de94761 - Browse repository at this point
Copy the full SHA de94761View commit details -
test: Apply 'Revert "[tokens-controller] Add actions
getState
, `add……DetectedTokens` and event `stateChange`"
Configuration menu - View commit details
-
Copy full SHA for 4b6c1d2 - Browse repository at this point
Copy the full SHA 4b6c1d2View commit details
Commits on Dec 21, 2023
-
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for a951492 - Browse repository at this point
Copy the full SHA a951492View commit details -
Configuration menu - View commit details
-
Copy full SHA for 541f8f4 - Browse repository at this point
Copy the full SHA 541f8f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 798bb09 - Browse repository at this point
Copy the full SHA 798bb09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1552041 - Browse repository at this point
Copy the full SHA 1552041View commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for 2451982 - Browse repository at this point
Copy the full SHA 2451982View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d020bc - Browse repository at this point
Copy the full SHA 6d020bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05cf2bd - Browse repository at this point
Copy the full SHA 05cf2bdView commit details -
Revert "test: remove unnecessary
.start()
calls"This reverts commit 73eccbf.
Configuration menu - View commit details
-
Copy full SHA for d8ced01 - Browse repository at this point
Copy the full SHA d8ced01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16e8bad - Browse repository at this point
Copy the full SHA 16e8badView commit details -
Configuration menu - View commit details
-
Copy full SHA for f67bead - Browse repository at this point
Copy the full SHA f67beadView commit details -
Merge branch 'main' into 231201-token-detection-controller-basecontro…
…llerv2-migration
Configuration menu - View commit details
-
Copy full SHA for 8e1cdf5 - Browse repository at this point
Copy the full SHA 8e1cdf5View commit details