chore(base-controller): Restore subscrbe property
#3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
The `subscribe` property was removed in #3590 because it is no longer used. It has been restored here so that we can release the `@metamask/base-controller` without any breaking changes. This property's description has been updated to clarify that it's no longer used, and it's now marked as deprecated.
Gudahtt
force-pushed
the
restore-subscribe-property
branch
from
bd2214b to
ceb11de
Compare
Gudahtt
added a commit
that referenced
this pull request
Dec 22, 2023
* origin/main: chore(base-controller): Restore `subscrbe` property (#3698)
Gudahtt
added a commit
that referenced
this pull request
Dec 22, 2023
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
subscribeproperty was removed in #3590 because it is no longer used. It has been restored here so that we can release the@metamask/base-controllerwithout any breaking changes.This property's description has been updated to clarify that it's no longer used, and it's now marked as deprecated.
References
Discussed in the v104 release candidate PR: #3695 (comment)
Changelog
@metamask/base-controllersubscribeproperty ofBaseControllerV2BaseControllerV1andBaseControllerV2controllers. It is no longer used, so it has been marked as deprecated.Checklist