Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant perDomainNetwork state #3989

Merged
merged 2 commits into from
Feb 27, 2024
Merged

remove redundant perDomainNetwork state #3989

merged 2 commits into from
Feb 27, 2024

Conversation

BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Feb 27, 2024 •
edited
Loading

Explanation

See here for more details

References

Changelog

@metamask/selected-network-controller

  • ADDED: SelectedNetworkController constructor now takes a getUseRequestQueue function.
  • REMOVED: SelectedNetworkController no longer has a perDappNetwork feature flag saved in state.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ BelfordZ marked this pull request as ready for review February 27, 2024 21:36
@BelfordZ BelfordZ requested a review from a team as a code owner February 27, 2024 21:36
@BelfordZ BelfordZ force-pushed the fix/remove-redundant-state branch from babf753 to 745c9df Compare February 27, 2024 21:42
@adonesky1 adonesky1 mentioned this pull request Feb 27, 2024
Merged
adonesky1
adonesky1 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 17c52d9 into main Feb 27, 2024
138 checks passed
@adonesky1 adonesky1 deleted the fix/remove-redundant-state branch February 27, 2024 23:17
@adonesky1
Copy link
Contributor

Just a note both of the changelog entries here are breaking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BelfordZ @adonesky1