Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines for writing controllers #4110

Merged
merged 17 commits into from
Sep 2, 2024
Merged

Add guidelines for writing controllers #4110

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
271cbd6
Add guidelines for writing controllers
mcmire Mar 26, 2024
8ef4993
AccountsControllerGetState -> AccountsControllerGetStateAction
mcmire Jul 9, 2024
35db85b
Tweak wording in first section
mcmire Jul 9, 2024
73cf66f
Fix typo
mcmire Jul 9, 2024
002a914
Use stronger language for exporting default state, and explain why no…
mcmire Jul 9, 2024
cb5242a
Clarify how action identifiers should be named
mcmire Jul 9, 2024
f79c325
Tweak name of internal action types guideline
mcmire Jul 9, 2024
635ff55
Tweak name of action types guideline
mcmire Jul 9, 2024
b4f335f
Reword 'options bag' guideline slightly
mcmire Jul 9, 2024
92fca54
Clarify name of the default state object
mcmire Jul 9, 2024
545e90e
Add section on metadata
mcmire Jul 9, 2024
88c8f38
Merge branch 'main' into add-controller-guidelines
mcmire Jul 9, 2024
7bea382
Tweak example
mcmire Jul 9, 2024
6dbedbb
Apply suggestions
mcmire Jul 9, 2024
229cf20
Update docs/writing-controllers.md
mcmire Jul 9, 2024
1e9577b
Merge branch 'main' into add-controller-guidelines
mikesposito Aug 26, 2024
cd3c95f
Merge branch 'main' into add-controller-guidelines
mikesposito Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading