Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(permission-controller): Clean up use of any #4171

Merged
merged 18 commits into from
Apr 26, 2024
Merged

refactor(permission-controller): Clean up use of any #4171

merged 18 commits into from
Apr 26, 2024

Commits on Apr 17, 2024

  1. refactor(permission-controller): Refactor "any" typecasts 

    Either replaces `any` with `@ts-expect-error` directives or leaves them
in place without a TODO to replace them. All remaining instances of
`any` are defensible.
    @rekmarks
    rekmarks committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0196028 View commit details
    Browse the repository at this point in the history

  2. fix(accounts-controller): Remove suddenly and mysteriously extraneous… 

    … ts-expect-error
    @rekmarks
    rekmarks committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    632ebc9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. refactor(permission-controller): Simplify switch in updatePermissions… 

    …ByCaveat
    @rekmarks
    rekmarks committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6b95853 View commit details
    Browse the repository at this point in the history

  2. refactor(permission-controller): Replace any types in Caveat.test.ts

    @rekmarks
    rekmarks committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f4cd213 View commit details
    Browse the repository at this point in the history

  3. refactor(permission-controller): Add specific types in getPermissions… 

    ….test.ts
    @rekmarks
    rekmarks committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a16abf9 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'main' into rekmarks-permission-controller-cleanup

    @rekmarks
    rekmarks authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e620020 View commit details
    Browse the repository at this point in the history

  2. refactor(acounts-controller): Remove ts-expect-error entirely

    @rekmarks
    rekmarks committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c54671b View commit details
    Browse the repository at this point in the history

  3. fix: Apply suggestions to Caveat.ts

    @rekmarks
    rekmarks committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ab7031b View commit details
    Browse the repository at this point in the history

  4. fix: Apply suggestions to Permission.ts

    @rekmarks
    rekmarks committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    26e48f1 View commit details
    Browse the repository at this point in the history

  5. fix: PermissionController.removeCaveat() type

    @rekmarks
    rekmarks committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    49d833c View commit details
    Browse the repository at this point in the history

  6. refactor: Replace ts-expect-error directives in tests where possible

    @rekmarks
    rekmarks committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    376d8f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. fix: Apply suggestions to permission controller and its tests

    @rekmarks
    rekmarks committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6f8fa3d View commit details
    Browse the repository at this point in the history

  2. fix: Replace all uses of any in permission controller tests

    @rekmarks
    rekmarks committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b7a275f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into rekmarks-permission-controller-cleanup

    @rekmarks
    rekmarks authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a6b7101 View commit details
    Browse the repository at this point in the history

  4. fix: Remove unnecessary any from constraint type

    @rekmarks
    rekmarks committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ee2ad01 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. refactor: Replace type casts with type assertions

    @rekmarks
    rekmarks committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    834d764 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into rekmarks-permission-controller-cleanup

    @rekmarks
    rekmarks authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1a948c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge branch 'main' into rekmarks-permission-controller-cleanup

    @rekmarks
    rekmarks authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1a53dab View commit details
    Browse the repository at this point in the history