TokenRatesController: providerConfig -> selectedNetworkClientId #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in TokenRatesController to get the currently selected chain and ticker, but `selectedNetworkClientId` can be used instead to get the currently selected network client, and then the appropriate information can be read from that object. This commit makes that transition so that we can fully drop `providerConfig`.
mcmire
force-pushed
the
remove-provider-config-from-token-rates-controller
branch
from
7d7cd54 to
958cc74
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
providerConfigstate property is being removed from NetworkController. Currently this property is used in TokenRatesController to get the currently selected chain and ticker, butselectedNetworkClientIdcan be used instead to get the currently selected network client, and then the appropriate information can be read from that object. This commit makes that transition so that we can fully dropproviderConfig.References
Progresses #4185.
Changelog
(Included in the PR.)
Checklist