Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission-controller lint violations #4537

Merged
merged 2 commits into from
Jul 18, 2024

Commits on Jul 17, 2024

  1. Fix permission-controller lint violations

    There are some `permission-controller` tests which attempt to push an
    async middleware function onto an engine. Although this works in
    practice, `@typescript-eslint` balks at this, because the type for
    `JsonRpcEngine.push` says it takes a `JsonRpcMiddleware`, and a
    `JsonRpcMiddleware` has a return type of `void`, not `Promise<void>`. We
    could change that return type to `void | Promise<void>` but that would
    cause other changes we may not want to make. So this commit merely
    ignores the lint violations.
    
    Interestingly, the lint violations caused by this discrepancy only
    appear locally and not on CI. I am not sure why this is.
    mcmire committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9e5b434 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    9d4af5a View commit details
    Browse the repository at this point in the history