fix(TXL-207): fixes gaps in transaction validation and async error logging

[dbrans]

Explanation

This PR repairs some gaps in our validation of transaction parameters:

• validate that if a transaction envelope type is specified that it is a valid type
• validate transaction parameters before right before adding transaction to state
• catch and log async errors

Notes

• The steps to reproduce in [Bug]: Transaction with invalid/unsupported type cannot be cleared from the wallet and remains as Unapproved metamask-extension#23180 revealed an async error that was being swallowed.

References

This PR will fix these bugs once clients are updated:

• Related: https://github.com/MetaMask/MetaMask-planning/issues/2341
• Related: [Bug]: Transaction with invalid/unsupported type cannot be cleared from the wallet and remains as Unapproved metamask-extension#23180

Changelog

@metamask/transaction-controller

• FIXED: Fixes gaps in transaction parameter validation and async error logging

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[dbrans]

Swapped operands so that compatibility can be determined synchronously by tx type in some cases.