Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NOTIFY-1102): add account sync analytics callbacks #4707

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat(NOTIFY-1102): add account sync analytics callbacks #4707

merged 1 commit into from
Sep 16, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Sep 16, 2024 •
edited
Loading

Explanation

This PR adds callbacks that will be used for analytics in the account sync context.

References

Notify-1102

Changelog

@metamask/profile-sync-controller

  • ADDED: onAccountAdded and onAccountNameUpdated account syncing big sync callbacks

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mathieuartu mathieuartu marked this pull request as ready for review September 16, 2024 12:34
@mathieuartu mathieuartu requested a review from a team as a code owner September 16, 2024 12:34
@mathieuartu mathieuartu merged commit d6be9f0 into main Sep 16, 2024
116 checks passed
@mathieuartu mathieuartu deleted the feat/add_account_sync_analytics_support branch September 16, 2024 12:42
Mrtenz added a commit that referenced this pull request Sep 16, 2024
@Mrtenz
Add changelog entry for #4707
17bb4b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieuartu @Prithpal-Sooriya