fix: profile-sync-controller mobile compilation issues

[Prithpal-Sooriya]

Explanation

Our package has exported async arrow functions, which cannot be compiled during the detox build android step on mobile.

See error logs

It is most likely related to this hermes error: facebook/hermes#1395

This removes the exported async arrow functions in the bundle for normal async functions.

Long term we should either:

• Add ESLint rules to prevent other devs or teams being burnt by this
• Or have a transpilation step to avoid async arrow functions.

References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1144

Changelog

@metamask/profile-sync-controller

• CHANGED: updated exported async arrow functions to normal async functions.

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[Prithpal-Sooriya]

@metamaskbot publish-preview

[github-actions]

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/accounts-controller": "18.2.1-preview-7ccbf59",
  "@metamask-previews/address-book-controller": "6.0.1-preview-7ccbf59",
  "@metamask-previews/announcement-controller": "7.0.1-preview-7ccbf59",
  "@metamask-previews/approval-controller": "7.0.4-preview-7ccbf59",
  "@metamask-previews/assets-controllers": "38.0.1-preview-7ccbf59",
  "@metamask-previews/base-controller": "7.0.1-preview-7ccbf59",
  "@metamask-previews/build-utils": "3.0.1-preview-7ccbf59",
  "@metamask-previews/chain-controller": "0.1.2-preview-7ccbf59",
  "@metamask-previews/composable-controller": "9.0.1-preview-7ccbf59",
  "@metamask-previews/controller-utils": "11.3.0-preview-7ccbf59",
  "@metamask-previews/ens-controller": "14.0.1-preview-7ccbf59",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-7ccbf59",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-7ccbf59",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-7ccbf59",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-7ccbf59",
  "@metamask-previews/keyring-controller": "17.2.1-preview-7ccbf59",
  "@metamask-previews/logging-controller": "6.0.1-preview-7ccbf59",
  "@metamask-previews/message-manager": "10.1.1-preview-7ccbf59",
  "@metamask-previews/name-controller": "8.0.1-preview-7ccbf59",
  "@metamask-previews/network-controller": "21.0.1-preview-7ccbf59",
  "@metamask-previews/notification-controller": "6.0.1-preview-7ccbf59",
  "@metamask-previews/notification-services-controller": "0.7.0-preview-7ccbf59",
  "@metamask-previews/permission-controller": "11.0.2-preview-7ccbf59",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-7ccbf59",
  "@metamask-previews/phishing-controller": "12.0.3-preview-7ccbf59",
  "@metamask-previews/polling-controller": "10.0.1-preview-7ccbf59",
  "@metamask-previews/preferences-controller": "13.0.3-preview-7ccbf59",
  "@metamask-previews/profile-sync-controller": "0.8.0-preview-7ccbf59",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-7ccbf59",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-7ccbf59",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-7ccbf59",
  "@metamask-previews/signature-controller": "19.1.0-preview-7ccbf59",
  "@metamask-previews/transaction-controller": "37.0.0-preview-7ccbf59",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-7ccbf59"
}

[Jonathansoufer]

LGTM