Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NOTIFY-1192): add DELETE endpoint support #4758

Merged
merged 3 commits into from
Oct 4, 2024
Merged

feat(NOTIFY-1192): add DELETE endpoint support #4758

merged 3 commits into from
Oct 4, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Oct 3, 2024 •
edited
Loading

Explanation

This PR adds profile-sync SDK and UserStorageController support for the DELETE endpoint.
This exposes new methods that permit deleting all user entries for a specific feature.

References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1192

Changelog

@metamask/profile-sync-controller

  • ADDED: UserStorageController and profile-sync SDK support for the DELETE all feature entries endpoint

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Oct 3, 2024
@mathieuartu mathieuartu marked this pull request as ready for review October 4, 2024 09:44
@mathieuartu mathieuartu requested a review from a team as a code owner October 4, 2024 09:44
@mathieuartu mathieuartu merged commit 9c8beb0 into main Oct 4, 2024
116 checks passed
@mathieuartu mathieuartu deleted the feat/delete_endpoint_support branch October 4, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieuartu @Prithpal-Sooriya