feat: fetch token rates across accounts #4759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
TokenRatesController
used to only fetch prices for tokens on the currently selected account. With this change, it will fetch prices for tokens across all accounts.This will power UI features like showing portfolio $ values in the account picker, and avoids needing to re-fetch prices when switching accounts which causes some UI lag.
References
Changelog
@metamask/assets-controllers
TokenRatesController
now fetches prices for tokens across all accountsChecklist