Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 214.0.0 #4762

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Release 214.0.0 #4762

merged 5 commits into from
Oct 4, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 4, 2024 •
edited
Loading

Explanation

This is an RC for v214.0.0

References

Changelog

@metamask/assets-controllers

  • CHANGED: Fetch token rates across all accounts instead of just the selected account in TokenRatesController

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@sahar-fehri sahar-fehri requested a review from a team as a code owner October 4, 2024 11:10
cryptodev-2s
cryptodev-2s approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cryptodev-2s
cryptodev-2s approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahar-fehri sahar-fehri merged commit 3c15eaf into main Oct 4, 2024
116 checks passed
@sahar-fehri sahar-fehri deleted the release/214.0.0 branch October 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahar-fehri @cryptodev-2s