fix: do not sync imported accounts #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
added
the
team-notifications
| account.metadata.keyring.type === KeyringTypes.hd || | ||
| account.metadata.keyring.type === KeyringTypes.simple | ||
| ); | ||
| return account.metadata.keyring.type === KeyringTypes.hd; |
There was a problem hiding this comment.
So thaaats what .simple is lol.
OK so we are now POSITIVE this is only wallet accounts?
There was a problem hiding this comment.
Yes, learnt the hard way 😂
WE ARE! 🚀
Prithpal-Sooriya
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixed an unintended behavior where we were syncing imported accounts.
References
https://consensyssoftware.atlassian.net/browse/NOTIFY-1215
Changelog
@metamask/profile-sync-controllerChecklist