refactor: remove message managers from signature controller #4785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial unit tests. Remove unnecessary types.
Add SIWE support. Add signing options support. Set origin and request ID.
Throw custom reject error. Mock individual messenger actions.
Add additional unit tests.
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Split large processSignatureRequest method. Always finish in switch statement. Add unit tests for emitted events.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
reviewed
Oct 16, 2024
OGPoyraz
approved these changes
Oct 16, 2024
vinistevam
approved these changes
Oct 16, 2024
matthewwalsh0
deleted the
refactor/signature-controller-remove-message-managers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In order to greatly simplify future maintenance and readability of the
SignatureControllerlogic, this PR completely removes any usage of the@metamask/message-managerpackage.This has intentionally been done as backwards compatible as possible meaning there should be zero functional breaking changes, and only very minor breaking changes due to alternate property types.
The state and public function signatures are unchanged, and the only addition is the primary usage of a
signatureRequestsobject to include all message / request data directly in the state, to avoid reliance on the legacymessagesgetter.The legacy state properties are automatically updated whenever the
signatureRequestsstate is updated, and all legacy state and getters have been marked asdeprecated.References
Fixes #1930
Related to #27787 (Extension Adoption)
Changelog
See updated changelogs for
signature-controllerandmessage-manager.Checklist