-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NotificationController
#4815
base: main
Are you sure you want to change the base?
Conversation
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/utils@9.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
RIP 🥲 |
The @MetaMask/notifications team will align with the @MetaMask/snaps team on this. Our notifications team were preparing the "notification unification" in Q1 (unify snaps, confirmations, our back-end notifications, and future notifications or alerts), but, as this seems to be moving forward, we can expedite it 😅. We can have a brainstorm and discussion on how we can create a unified/orchestrated notification controller that:
This can be done in iterative steps. I'm just bringing this up as the current |
Removes the
NotificationController
in favor ofNotificationServicesController
, see #4809