Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Some change was introduced that caused an issue where pending approvals are not getting cleared when
wallet_switchEthereumChain
calls occur.This causes an issue in the
QueuedRequestController
where the#processingRequestCount
value does not get updated correctly since certain pending confirmation rejections never resolve.This then causes this condition to never obtain, meaning that the
this.#originOfCurrentBatch
never gets unset which causes subsequent requests to always get queued.References
Changelog
@metamask/package-a
@metamask/package-b
Checklist