Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip fix? #4824

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

wip fix? #4824

wants to merge 3 commits into from

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Oct 21, 2024

Explanation

Some change was introduced that caused an issue where pending approvals are not getting cleared when wallet_switchEthereumChain calls occur.

This causes an issue in the QueuedRequestController where the #processingRequestCount value does not get updated correctly since certain pending confirmation rejections never resolve.

This then causes this condition to never obtain, meaning that the this.#originOfCurrentBatch never gets unset which causes subsequent requests to always get queued.

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@adonesky1
Copy link
Contributor Author

@metamaskbot publish-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant