Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable notifications #4890

Merged
merged 2 commits into from
Nov 1, 2024
Merged

fix: disable notifications #4890

merged 2 commits into from
Nov 1, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Nov 1, 2024

Explanation

  • What is the current state of things and why does it need to change? If notifications are disable while there is an unread notification, the notifications are wiped from state.
  • What is the solution your changes offer and how does it work? In the disable function, we repopulate the list with the currently exist snap notifications.
  • Are there any changes whose purpose might not obvious to those unfamiliar with the domain? This was only uncovered in manual QA in my extension PR: feat: Integrate Snap notification services metamask-extension#27975

Changelog

@metamask/notification-services-controller

  • FIX: Updated disable notifications function to repopulate state with existing snap notifications instead of emptying the list entirely.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@hmalik88 hmalik88 requested a review from a team as a code owner November 1, 2024 19:23
@hmalik88 hmalik88 merged commit 096f2d1 into main Nov 1, 2024
120 checks passed
@hmalik88 hmalik88 deleted the hm/fix-disable-notifications branch November 1, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants