feat: multi-chain-token-detection

[salimtb]

Explanation

This PR modifies the token detection controller to support detecting tokens across multiple network client IDs at once, instead of handling only a single network client ID. This enhancement allows for more efficient token detection and state updates across multiple chains in a single polling cycle.

Key Changes

Multi-Chain Token Detection:

Updated the token detection controller to accept an array of network client IDs as input.
On each polling interval, the controller will detect tokens and update the state for all chains in the provided array.

References

Changelog

@metamask/assets-controllers

• CHANGED: the polling token autodetection take an array of chainIds now

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[salimtb]

Explanation: we don't need to handle this case since the detection is multichain now , this is why we're removing this code

[salimtb]

The purpose of this function is to convert an array of chainId values into an array of objects, each containing { chainId, networkClientId } pairs. If a network is selected, it assigns selectedNetworkClientId as the networkClientId; otherwise, it uses the first available network client ID. This function will be used within detectTokens to facilitate token detection in a loop

[Prithpal-Sooriya]

So much syntactic sugar here makes this too sweet 🤣

To summarise this:

1. Grabs tokens for a specific chain, for a specific address
2. Then we filter over these tokens to make sure that we get tokens that have not been imported before (newly detected tokens)
3. Otherwise we will fallback to an empty array.

I wonder if we can clean this up a little (I think it's the ternary switch that adds complexity).

// Bad at naming
const foobar = allDetectedTokens?.[interactingChainId]?.[this.#getSelectedAddress()] ?? [];
const newDetectedTokens = foobar.filter(t => !importedTokensMap[t.address.toLowerCase()])

[Prithpal-Sooriya]

nit - we can do this later in a future PR.

There is a lot of things happening in the controller/test. It would be nice to move/group some composable "arrange" functions to clean up these tests and make it clear what we are testing.

[Prithpal-Sooriya]

lol

[Prithpal-Sooriya]

clean up later