Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
As autodetection is now multi-chain, the
addTokens
function must be adjusted by taking theallTokens
and filter onchainId
into account to avoid importing the wrong tokens.The
addTokens
function currently operates by taking the existing list of imported tokens ( without considering the network ) and adding the tokens specified in thetokensToImport
parameter. This approach can result in incorrect tokens being imported, as it doesn’t filter by chain. To address this, we useallTokens
to ensure accurate filtering by chain.References
Changelog
@metamask/assets-controllers
allTokens
Checklist