Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(27254): implement new remote-feature-flag-controller #4931

Merged
merged 37 commits into from
Nov 28, 2024
Merged

feat(27254): implement new remote-feature-flag-controller #4931

merged 37 commits into from
Nov 28, 2024

Commits on Nov 28, 2024

  1. feat(27254): implement new remote-feature-flag-controller

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d11ecf7 View commit details
    Browse the repository at this point in the history

  2. feat(27254): refactor based on pr review

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5b05af2 View commit details
    Browse the repository at this point in the history

  3. feat(27254): address feedback - round 2

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f4c8f30 View commit details
    Browse the repository at this point in the history

  4. Add jsdoc comments to remote-feature-flag-controller.ts

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ee6f771 View commit details
    Browse the repository at this point in the history

  5. feat(27254): fix lint errors for test file

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    091caf7 View commit details
    Browse the repository at this point in the history

  6. feat(27254): code review round 3

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    03ef2c7 View commit details
    Browse the repository at this point in the history

  7. feat(27254): add tests for controller for error catching

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3cf5c2a View commit details
    Browse the repository at this point in the history

  8. Update packages/remote-feature-flag-controller/package.json: remove `… 

    …private: true`

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
    @danjm @mcmire @DDDDDanica
    2 people authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    776d0cc View commit details
    Browse the repository at this point in the history

  9. Update packages/remote-feature-flag-controller/src/logger.ts: correct… 

    … name passed to createProjectLogger

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
    @danjm @mcmire @DDDDDanica
    2 people authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    6e2f1f9 View commit details
    Browse the repository at this point in the history

  10. create module logger within remote-feature-flag-controller.js itself

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    1839dc3 View commit details
    Browse the repository at this point in the history

  11. Pluralize variable/property names to better reflect the data

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    2cb6b97 View commit details
    Browse the repository at this point in the history

  12. Simplify error handling and promise resolution within remote feature … 

    …flag controller
    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    1bd93c6 View commit details
    Browse the repository at this point in the history

  13. Pluralize remoteFeatureFlag within remote-feature-flag-controller.* f… 

    …iles
    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3ba6395 View commit details
    Browse the repository at this point in the history

  14. Lint fix

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8fcae88 View commit details
    Browse the repository at this point in the history

  15. Update descriptions in readme and package.json

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    1392957 View commit details
    Browse the repository at this point in the history

  16. Update license to use MIT and Apache 2

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b5278f5 View commit details
    Browse the repository at this point in the history

  17. Return cached data if disabled is true; complete renaming to remoteFe… 

    …atureFlags (plural) and clean up a couple of tests
    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    fe1b382 View commit details
    Browse the repository at this point in the history

  18. Lint package.json

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5d682a9 View commit details
    Browse the repository at this point in the history

  19. Validate that data returned by the API in fetchRemoteFeatureFlags is … 

    …an array
    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3b55e9e View commit details
    Browse the repository at this point in the history

  20. Add name property to feature flag objects

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d0b6b8e View commit details
    Browse the repository at this point in the history

  21. Lint package.json

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f671453 View commit details
    Browse the repository at this point in the history

  22. Remove use of deferred promise in getRemoteFeatureFlags

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0e5f507 View commit details
    Browse the repository at this point in the history

  23. Clean up lint and tests

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    041cbff View commit details
    Browse the repository at this point in the history

  24. feat(27254): fix line issue in test file

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    de16e16 View commit details
    Browse the repository at this point in the history

  25. feat(27254): increase jest threshold

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    be6ea29 View commit details
    Browse the repository at this point in the history

  26. feat(27254): create a LICENSE file that references both licenses:

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    759fe89 View commit details
    Browse the repository at this point in the history

  27. Re-add call to updateCache and update unit tests to verify that updat… 

    …eCache is called
    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    af8efcf View commit details
    Browse the repository at this point in the history

  28. feat(27254): flattern data from service side

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    1a0eb16 View commit details
    Browse the repository at this point in the history

  29. Refactor getRemoteFeatureFlags to updateRemoteFeatureFlags, such that… 

    … it no longer returns feature flags
    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    389d115 View commit details
    Browse the repository at this point in the history

  30. Use # instead of private in remoteFeatureFlagsController

    @danjm @DDDDDanica
    danjm authored and DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    df86c38 View commit details
    Browse the repository at this point in the history

  31. feat(27254): flattern data applied to controller

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    cbeb4ae View commit details
    Browse the repository at this point in the history

  32. feat(27254): increase test coverage

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0517f57 View commit details
    Browse the repository at this point in the history

  33. feat(27254): modify test names to fit new patter

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8ef4534 View commit details
    Browse the repository at this point in the history

  34. feat(27254): lint fix

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    96ddeb9 View commit details
    Browse the repository at this point in the history

  35. feat(27254): export in types

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0a0a118 View commit details
    Browse the repository at this point in the history

  36. feat(27254): remove unneeed api response

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    791fd6f View commit details
    Browse the repository at this point in the history

  37. feat(27254): remove unneeed api response

    @DDDDDanica
    DDDDDanica committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    37d0bcc View commit details
    Browse the repository at this point in the history