Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dec to gwi #504

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix dec to gwi #504

merged 1 commit into from
Jul 1, 2021

Conversation

brad-decker
Copy link
Contributor

Fixes the decToGwei method by changing toFixed(3) to toFixed(9) and changing BN_1000 to BN_1GWEI_IN_WEI which was '1_000' but is now '1_000_000_000';

@brad-decker brad-decker requested a review from a team as a code owner July 1, 2021 14:57
@brad-decker brad-decker changed the base branch from main to draft-gasfee-controller July 1, 2021 14:57
@brad-decker brad-decker requested review from danjm and Gudahtt July 1, 2021 14:57
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 1c7862d into draft-gasfee-controller Jul 1, 2021
@brad-decker brad-decker deleted the fix-dec-to-gwi branch July 1, 2021 15:02
brad-decker added a commit that referenced this pull request Jul 2, 2021
brad-decker added a commit that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants