use ethjs-unit for unit conversions #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
force-pushed
the
superior-unit-conversions
branch
from
34da470 to
6be939a
Compare
brad-decker
force-pushed
the
superior-unit-conversions
branch
from
6be939a to
78b4c52
Compare
darkwing
approved these changes
Jul 1, 2021
Gudahtt
reviewed
Jul 2, 2021
| if (Number.isNaN(n)) { | ||
| return new BN(0); | ||
| } | ||
| return toWei(n.toString(), 'gwei'); |
There was a problem hiding this comment.
It looks like this now throws an error if you input a number with too many decimal places. Beforehand it would ignore the extra decimals instead.
This seems safer. I just wanted to note the change in behaviour.
brad-decker
added a commit
that referenced
this pull request
Jul 2, 2021
brad-decker
added a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a hex wei to dec gwei conversion utility and i didn't see one existed. I also saw we already have ethjs-unit included as dependency of a dependency, this is what web3.js uses for its .toWei/.fromWei functions...
It uses BN under the hood but is far more robust than our utilities.