Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(accounts): Rename ControllerMessenger to Messenger #5090

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Explanation

Rename ControllerMessenger to Messenger in the @metamask/accounts-controller package.

References

Relates to #4538

Changelog

No functional changes.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt Gudahtt force-pushed the messenger-rename-accounts branch from b8d5827 to 400548f Compare December 20, 2024 06:07
@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 06:12
@Gudahtt Gudahtt requested review from a team as code owners December 20, 2024 06:12
@Gudahtt Gudahtt force-pushed the messenger-rename-accounts branch 2 times, most recently from 3763cd3 to cee99b0 Compare January 10, 2025 00:00
Rename `ControllerMessenger` to `Messenger` in the
`@metamask/accounts-controller` package. The
`AccountsControllerMessenger` type export was renamed to
`AccountsMessenger`, but the old name is preserved as an alias.

Relates to #4538
This removes the only functional change in this PR
@Gudahtt Gudahtt force-pushed the messenger-rename-accounts branch from cee99b0 to 6e676ae Compare January 10, 2025 00:00
cryptodev-2s
cryptodev-2s previously approved these changes Jan 10, 2025
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt enabled auto-merge (squash) January 10, 2025 00:20
@Gudahtt Gudahtt merged commit d2f0b41 into main Jan 31, 2025
124 checks passed
@Gudahtt Gudahtt deleted the messenger-rename-accounts branch January 31, 2025 16:18
@Ahad2287

This comment has been minimized.

@Ahad2287 Ahad2287 mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants