Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw explicit error when KeyringController is locked #5172

Merged
merged 11 commits into from
Feb 11, 2025
+537 −34
Merged

fix: throw explicit error when KeyringController is locked #5172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ccd406e
chore: fix lint warnings in `KeyringController`
mikesposito Jan 17, 2025
059d3ba
Merge branch 'main' into mikesposito/lint-fix
mikesposito Jan 17, 2025
e8e4109
fix: throw explicit error when `KeyringController` is locked
mikesposito Jan 17, 2025
18d72a8
adjust coverage
mikesposito Jan 17, 2025
8794120
refactor: rewrite `getKeyringForAddress`
mikesposito Jan 17, 2025
f712653
revert: use `withKeyring` in `addNewAccount`
mikesposito Jan 17, 2025
c60cc5a
refactor: test primary keyring absence
mikesposito Jan 17, 2025
1a232ea
Merge branch 'main' into fix/assert-controller-unlocked
mikesposito Feb 5, 2025
f811be0
throw error for `exportSeedPhrase`
mikesposito Feb 11, 2025
2dd3921
test: add cases for locked controller
mikesposito Feb 11, 2025
ca4b0d2
Merge branch 'main' into fix/assert-controller-unlocked
mikesposito Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/keyring-controller/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ module.exports = merge(baseConfig, {
// An object that configures minimum threshold enforcement for coverage results
coverageThreshold: {
global: {
branches: 95.51,
branches: 94.26,
functions: 100,
lines: 99.07,
statements: 99.08,
lines: 98.96,
statements: 98.98,
},
},

Expand Down
Loading
Loading