Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mark @metamask/snaps-controllers peer dependency bump as breaking in CHANGELOG #5267

Merged
merged 2 commits into from
Feb 4, 2025
Merged

chore: mark @metamask/snaps-controllers peer dependency bump as breaking in CHANGELOG #5267

merged 2 commits into from
Feb 4, 2025

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 4, 2025 •
edited
Loading

Explanation

This PR adds the missing breaking change keyword to the changelog entry for the @metamask/snaps-controllers peer dependency bump, which was overlooked in PR #5265.

References

Changelog

See CHANGELOG for changes

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@cryptodev-2s cryptodev-2s requested review from a team as code owners February 4, 2025 16:40
@cryptodev-2s cryptodev-2s changed the title chore: mark @metamask/snaps-controllers bump CHANGELOG entry as breaking chore: mark @metamask/snaps-controllers peer dependency bump as breaking in CHANGELOG Feb 4, 2025
@cryptodev-2s cryptodev-2s self-assigned this Feb 4, 2025
@cryptodev-2s cryptodev-2s requested a review from mcmire February 4, 2025 16:41
mcmire
mcmire approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@cryptodev-2s cryptodev-2s enabled auto-merge (squash) February 4, 2025 16:53
@cryptodev-2s cryptodev-2s merged commit 69da3e6 into main Feb 4, 2025
127 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/fix-snaps-packages-bump-changelogs branch February 4, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees

@cryptodev-2s cryptodev-2s

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptodev-2s @mcmire