feat: transaction batch security validation #5526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
force-pushed
the
feat/batch-validate-security
branch
from
c3c4c63 to
7ecf950
Compare
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
previously approved these changes
Mar 25, 2025
pedronfigueiredo
previously approved these changes
Mar 25, 2025
vinistevam
previously approved these changes
Mar 25, 2025
matthewwalsh0
dismissed stale reviews from vinistevam, pedronfigueiredo, and OGPoyraz
via
785aec4
matthewwalsh0
force-pushed
the
feat/batch-validate-security
branch
from
7ecf950 to
785aec4
Compare
vinistevam
approved these changes
Mar 25, 2025
matthewwalsh0
added a commit
that referenced
this pull request
Mar 25, 2025
Support triggering security validation in the client while processing transaction batches. Specifically: - Add `ValidateSecurityRequest` type. - Add optional `validateSecurity` callback to `TransactionBatchRequest` type. - Add optional `securityAlertId` to `AddTransactionBatchRequest` type. - Add optional `securityAlertId` to `SecurityAlertResponse` type. - Call `validateSecurity` callback after generating EIP-7702 transaction. - Include `delegationMock` if an EIP-7702 type 4 transaction. Relates to [ See `CHANGELOG.md`. - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Support triggering security validation in the client while processing transaction batches.
Specifically:
ValidateSecurityRequesttype.validateSecuritycallback toTransactionBatchRequesttype.securityAlertIdtoAddTransactionBatchRequesttype.securityAlertIdtoSecurityAlertResponsetype.validateSecuritycallback after generating EIP-7702 transaction.delegationMockif an EIP-7702 type 4 transaction.References
Relates to #31263
Changelog
See
CHANGELOG.md.Checklist