fix: Remove async operation from updateTransactionGasFees

[OGPoyraz]

Explanation

This PR aims to fix an issue where updateTransactionGasFees updater rejects updating draft state with following error:
TypeError: Cannot perform 'get' on a proxy that has been revoked

The fix is to remove that async operation because it's unnecessary to check it again since it's been check while addTransaction

References

Changelog

@metamask/transaction-controller

• FIXED: Fix type error when enableTxParamsGasFeeUpdates is set to true

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[matthewwalsh0]

This is fired from an event listener, so there is technically now a risk that if we have a very slow update, that they begin to overlap.

Should we add a mutex to prevent two happening at once?

[OGPoyraz]

Good call Matthew, added gasFeeUpdateMutexes map for locking same transactionId gas updates now.

[matthewwalsh0]

Sorry Goktug, I've looked into this deeper and I don't think we need to call getEIP1559Compatability at all meaning this doesn't need to be async and no mutexes.

Because we already call this inside addTransaction and then go through validateEIP1559Compatibility which would throw if there was a maxFeePerGas or maxPriorityFeePerGasprovided but the network wasn't EIP-1159.

So we could instead just set the type early at that point in addTransaction based on the existing compatibility call, assuming the user didn't explicit specify the legacy type.

Then here, we would just trust the envelope type?

[OGPoyraz]

Thanks Matthew, I added a tiny function that sets type after validation if nothing defined, so we make sure that type is always present and it give us the flexibility to remove that async check.