Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 19, 2025

Explanation

The ListenerV2 export of the next version of BaseController has been renamed to StateChangeListener.

References

Fixes #6338

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt Gudahtt force-pushed the rename-listener-v2-export branch from 4018469 to 1612afe Compare August 19, 2025 20:19
@Gudahtt Gudahtt force-pushed the messenger-migrate-base-controller branch 2 times, most recently from ae71891 to 67c7853 Compare August 20, 2025 14:04
Base automatically changed from messenger-migrate-base-controller to main August 20, 2025 14:10
@Gudahtt Gudahtt force-pushed the rename-listener-v2-export branch from 1612afe to d933a21 Compare August 20, 2025 14:14
@Gudahtt Gudahtt marked this pull request as ready for review August 20, 2025 14:21
@Gudahtt Gudahtt requested a review from a team as a code owner August 20, 2025 14:21
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

The `ListenerV2` export of the `next` version of `BaseController` has
been renamed to `StateChangeListener`.

Fixes #6338
@Gudahtt Gudahtt force-pushed the rename-listener-v2-export branch from d933a21 to 6945b1b Compare August 20, 2025 14:32
@Gudahtt Gudahtt enabled auto-merge (squash) August 20, 2025 14:32
@Gudahtt Gudahtt merged commit b9634cf into main Aug 20, 2025
227 checks passed
@Gudahtt Gudahtt deleted the rename-listener-v2-export branch August 20, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[base-controller] Rename ListenerV2 to StateChangeListener

4 participants