Skip to content

Conversation

@matthiasgeihs
Copy link
Contributor

@matthiasgeihs matthiasgeihs commented Aug 22, 2025

Explanation

Migrate messenger for SeedlessOnboardingController

References

#5626

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates SeedlessOnboardingController to the new @metamask/messenger API and base-controller/next, and renames state metadata flag from anonymous to includeInDebugSnapshot.

  • Seedless Onboarding Controller:
    • Migrate from @metamask/base-controller messenger to @metamask/messenger (SeedlessOnboardingController.ts, types.ts).
    • Switch imports to @metamask/base-controller/next.
    • Rename state metadata property anonymousincludeInDebugSnapshot and update usages.
  • Tests:
    • Replace legacy messenger mocks with new @metamask/messenger-based root/restricted messengers; update fixtures and test helpers.
    • Update deriveStateFromMetadata calls to use includeInDebugSnapshot.
  • Docs/Meta:
    • Update CHANGELOG.md with breaking changes notes.
    • Update README dependency graph (add seedless_onboarding_controller --> messenger, and show new edge for eip_7702_internal_rpc_middleware).
  • Dependencies:
    • Add @metamask/messenger dependency.

Written by Cursor Bugbot for commit 452fa23. This will update automatically on new commits. Configure here.

@matthiasgeihs matthiasgeihs marked this pull request as ready for review August 22, 2025 10:13
@matthiasgeihs matthiasgeihs requested review from a team as code owners August 22, 2025 10:13
@mikesposito mikesposito enabled auto-merge October 27, 2025 12:19
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 2bdfdea Oct 27, 2025
274 of 285 checks passed
@mikesposito mikesposito deleted the mg/seedless-controller/migrate-messenger branch October 27, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants