-
-
Notifications
You must be signed in to change notification settings - Fork 256
refactor: migrate AddressBookController to @metamask/messenger
#6383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate AddressBookController to @metamask/messenger
#6383
Conversation
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing Cursor noticed, but LGTM regardless.
| contactUpdatedListener, | ||
| ); | ||
| messenger.subscribe( | ||
| rootMessenger.subscribe( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yes. Perhaps we can remove the other type assertion?
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
This PR migrates the
AddressBookControllerclass to the new@metamask/messengercomm system, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates
AddressBookControllerto the new@metamask/messengerAPI, updates metadata flag, tests, and package references.@metamask/messengerand@metamask/base-controller/nextAPIs; updateAddressBookControllerMessengertype.messagingSystem.publish/registerActionHandlerwithmessenger.publish/registerActionHandler.anonymoustoincludeInDebugSnapshot.packages/address-book-controller/src/AddressBookController.test.ts):Messengerwith root/namespace setup; subscribe via root messenger.includeInDebugSnapshot.@metamask/messengerand TS project references; update README dependency graph.Written by Cursor Bugbot for commit 41449c6. This will update automatically on new commits. Configure here.