Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Aug 26, 2025

Explanation

This PR migrates the AnnouncementController class to the new @metamask/messenger comm system, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates AnnouncementController to @metamask/messenger, renames metadata flag, and updates tests/config/docs accordingly.

  • Announcement Controller:
    • Migrate to @metamask/messenger Messenger; update imports to @metamask/base-controller/next.
    • Change metadata key from anonymous to includeInDebugSnapshot.
    • Update AnnouncementControllerMessenger type to use Messenger.
  • Tests:
    • Replace restricted messenger setup with new Messenger hierarchy; update imports and metadata key usage.
  • Package/Config:
    • Add dependency @metamask/messenger@^0.3.0 and TS project references to packages/messenger.
  • Docs:
    • Update README.md dependency graph to show announcement_controller --> messenger.
    • Add breaking-change notes to CHANGELOG.md.

Written by Cursor Bugbot for commit dc1f98f. This will update automatically on new commits. Configure here.

@mikesposito mikesposito marked this pull request as ready for review August 26, 2025 12:23
@mikesposito mikesposito requested review from a team as code owners August 26, 2025 12:23
@mikesposito mikesposito mentioned this pull request Aug 26, 2025
43 tasks
mcmire
mcmire previously approved these changes Aug 28, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito enabled auto-merge (squash) September 23, 2025 10:02
mcmire
mcmire previously approved these changes Oct 7, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit 0f3227f into main Oct 27, 2025
256 of 257 checks passed
@mikesposito mikesposito deleted the mikesposito/messenger/announcement-controller branch October 27, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants