-
-
Notifications
You must be signed in to change notification settings - Fork 256
refactor: migrate AppMetadataController to @metamask/messenger
#6385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate AppMetadataController to @metamask/messenger
#6385
Conversation
packages/app-metadata-controller/src/AppMetadataController.test.ts
Outdated
Show resolved
Hide resolved
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
It's unclear to me why the code scanner workflow is failing. I don't see any issues. |
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
This PR migrates the
AppMetadataControllerclass to the new@metamask/messengercomm system, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates
AppMetadataControllerto the new@metamask/messenger, updates metadata flag names, and aligns tests and configs withbase-controller/next.RestrictedMessenger(@metamask/base-controller) toMessenger(@metamask/messenger); update types and construction of namespaced messengers in tests.@metamask/base-controller/nextand useBaseControllerfromnext.anonymoustoincludeInDebugSnapshot; updatederiveStateFromMetadatausages.@metamask/messengerand update TS references (tsconfig.json,tsconfig.build.json).CHANGELOG.mdwith BREAKING changes.app_metadata_controller --> messengerlink.Written by Cursor Bugbot for commit 8232827. This will update automatically on new commits. Configure here.