-
-
Notifications
You must be signed in to change notification settings - Fork 255
refactor: migrate ShieldController to @metamask/messenger
#6497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShieldController to @metamask/messengerShieldController to @metamask/messenger
43 tasks
mcmire
requested changes
Sep 10, 2025
13b185c to
0517d4f
Compare
0517d4f to
84486cd
Compare
mcmire
previously approved these changes
Oct 7, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…r/shield-controller
Mrtenz
reviewed
Oct 27, 2025
Mrtenz
reviewed
Oct 27, 2025
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
cryptodev-2s
commented
Oct 27, 2025
Mrtenz
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
ShieldControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates ShieldController to @metamask/messenger, adds getState action, renames metadata key, and updates tests and configs accordingly.
@metamask/messenger(replaceRestrictedMessenger; switch tomessenger.subscribe/publish/unsubscribe; import controller types from@metamask/base-controller/next).ShieldControllerGetStateActionand export viasrc/index.ts.anonymoustoincludeInDebugSnapshot.rootMessenger, adjust mocks and utils to use@metamask/messenger.@metamask/messenger; include TS references topackages/messenger.shield_controller --> messengerandeip_7702_internal_rpc_middleware --> controller_utils.Written by Cursor Bugbot for commit 3e00774. This will update automatically on new commits. Configure here.