-
-
Notifications
You must be signed in to change notification settings - Fork 255
refactor: migrate RateLimitController to @metamask/messenger
#6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate RateLimitController to @metamask/messenger
#6503
Conversation
faa66e5 to
5ba04c4
Compare
5ba04c4 to
b4e2db0
Compare
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, noticed one thing.
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…r/rate-limit-controller
Pull Request is not mergeable
Explanation
This PR migrates
RateLimitControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates RateLimitController to the new @metamask/messenger, updates types/tests, and renames metadata flag; adds dependency and updates docs/config.
RestrictedMessenger(base-controller) toMessengerfrom@metamask/messengerandBaseControllerfrom@metamask/base-controller/next.messenger.registerActionHandlerand adjust types (RateLimitMessenger, action/event types,controllerName).anonymoustoincludeInDebugSnapshot.@metamask/messenger.@metamask/messenger@^0.3.0; update TS project references.rate_limit_controller --> messenger; addeip_7702_internal_rpc_middleware --> controller_utils.RateLimitController.ts.Written by Cursor Bugbot for commit b0aab99. This will update automatically on new commits. Configure here.