-
-
Notifications
You must be signed in to change notification settings - Fork 256
feat: Add new metadata properties to Web3Auth controllers #6504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0957aef to
17317a4
Compare
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
matthiasgeihs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the PR.
Note that several values need to be changed. In particular, access tokens should not be part of the state log.
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
Sorry, that was wrong. I misread the code and thought it would conditionally include the values, depending on whether they are present or not. Now I understand that |
matthiasgeihs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, can you please revert some of my requested changes. There was a misunderstanding on my end. See #6504 (comment).
| includeInStateLogs: (pendingToBeRevokedTokens) => | ||
| !isNullOrUndefined(pendingToBeRevokedTokens) && | ||
| pendingToBeRevokedTokens.length > 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to be more creative here as the controller sometimes sets this key to an empty array
matthiasgeihs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…Controller`" This reverts commit f8b67c4.
9c7ff4f to
e66248b
Compare
Explanation
The new metadata properties
includeInStateLogsandusedInUihave been added to all controllers maintained by the Web3Auth team.References
includeInStateLogsandusedInUicontroller metadata properties #6443Checklist