-
-
Notifications
You must be signed in to change notification settings - Fork 256
refactor: migrate MultichainAccountService to @metamask/messenger
#6544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cryptodev-2s
merged 17 commits into
main
from
cryptodev-2s/messenger/multichain-account-service
Oct 27, 2025
Merged
refactor: migrate MultichainAccountService to @metamask/messenger
#6544
cryptodev-2s
merged 17 commits into
main
from
cryptodev-2s/messenger/multichain-account-service
Oct 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
18f8701 to
2ea0719
Compare
2ea0719 to
f22848c
Compare
mcmire
previously approved these changes
Sep 10, 2025
…r/multichain-account-service
…r/multichain-account-service
mikesposito
previously approved these changes
Oct 27, 2025
FrederikBolding
previously approved these changes
Oct 27, 2025
…r/multichain-account-service
b90d0ca
packages/multichain-account-service/src/MultichainAccountService.test.ts
Show resolved
Hide resolved
FrederikBolding
approved these changes
Oct 27, 2025
auto-merge was automatically disabled
October 27, 2025 13:11
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
MultichainAccountServiceto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrate
MultichainAccountServiceand tests from@metamask/base-controllermessenger to the new@metamask/messenger, updating types, helpers, configs, and dependencies.RestrictedMessengerfrom@metamask/base-controllerwith newMessengerfrom@metamask/messengerinsrc/types.tsand all usages.RootMessengertest helper and implement delegation-basedgetMultichainAccountServiceMessengerinsrc/tests/messenger.ts.rootMessengerforregisterActionHandler/publishand pass restricted messenger to providers/service.@metamask/messengertopackages/multichain-account-service/package.jsonand reference it intsconfig*.json.multichain_account_service --> messenger.@metamask/messengerand expects itsMessengertype.Written by Cursor Bugbot for commit b90d0ca. This will update automatically on new commits. Configure here.